feat: add id to Trackers and manage with simple Map

src/core/crosslytics.spec.ts

@@ -16,6 +16,7 @@ class TestEvent extends TrackedEvent<TestEventArgs> {
 }
 
 class TestTracker implements Tracker {
+  constructor(public id: string) {}
   public identify(identity: Identity) {
     return;
   }
@@ -26,20 +27,29 @@ class TestTracker implements Tracker {
 
 test('Should only register a Tracker once', t => {
   const cl = new Crosslytics();
-  const tracker = new TestTracker();
-  cl.registerTracker(tracker);
-  cl.registerTracker(tracker);
-  t.is(cl.trackers.length, 1);
+  const tracker = new TestTracker('test');
+  cl.trackers.set(tracker.id, tracker);
+  cl.trackers.set(tracker.id, tracker);
+  t.is(cl.trackers.size, 1);
 });
 
-test('Should deregister a Tracker', t => {
+test('Should overwrite Trackers by id', t => {
   const cl = new Crosslytics();
-  const trackerA = new TestTracker();
-  const trackerB = new TestTracker();
-  cl.registerTracker(trackerA);
-  cl.registerTracker(trackerB);
-  t.is(cl.trackers.length, 2);
-  cl.deregisterTracker(trackerB);
-  cl.deregisterTracker(trackerB);
-  t.is(cl.trackers.length, 1);
+  const trackerA = new TestTracker('test');
+  const trackerB = new TestTracker('test');
+  cl.trackers.set(trackerA.id, trackerA);
+  cl.trackers.set(trackerB.id, trackerB);
+  t.is(cl.trackers.size, 1);
+});
+
+test('Should deregister a Tracker once', t => {
+  const cl = new Crosslytics();
+  const trackerA = new TestTracker('test');
+  const trackerB = new TestTracker('test2');
+  cl.trackers.set(trackerA.id, trackerA);
+  cl.trackers.set(trackerB.id, trackerB);
+  t.is(cl.trackers.size, 2);
+  cl.trackers.delete(trackerA.id);
+  cl.trackers.delete(trackerA.id);
+  t.is(cl.trackers.size, 1);
 });

src/core/crosslytics.ts

@@ -6,25 +6,13 @@ import { Tracker } from './tracker';
  * Main API entry point
  */
 export class Crosslytics {
-  public identity: Identity;
-
-  public readonly trackers = new Array<Tracker>();
-  public registerTracker(tracker: Tracker) {
-    if (this.trackers.indexOf(tracker) >= 0) {
-      return;
-    }
-
-    this.trackers.push(tracker);
-  }
-
-  public deregisterTracker(tracker: Tracker) {
-    const index = this.trackers.indexOf(tracker);
-    if (index >= 0) {
-      this.trackers.splice(index, 1);
-    }
-  }
+  public readonly trackers = new Map<string, Tracker>();
 
   public async track<T>(event: TrackedEvent<T>) {
-    return this.trackers.map(t => t.track(event));
+    const promises = [];
+    for (const tracker of this.trackers.values()) {
+      promises.push(tracker.track(event));
+    }
+    return Promise.all(promises);
   }
 }

src/core/tracker.ts

@@ -6,6 +6,7 @@ import { TrackedEvent } from './trackedEvent';
  * that ultimately receives your `TrackedEvent`s.
  */
 export interface Tracker {
+  id: string;
   identify(identity: Identity): void;
   track<T>(event: TrackedEvent<T>): Promise<void>;
 }