Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DiscoveryInfo key names #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix DiscoveryInfo key names #111

wants to merge 1 commit into from

Conversation

jacobsalmela
Copy link
Collaborator

Summary and Scope

Sets the correct key names for DiscoveryInfo

Issues and Related PRs

  • Relates to

Testing

Tested on:

  • Local development environment

Test description:

Used the spec to generate a go library and tested unmarshalling a redfishEndpoint.

Risks and Mitigations

Low

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jacobsalmela jacobsalmela requested a review from a team as a code owner April 26, 2023 16:04
@jacobsalmela jacobsalmela self-assigned this Apr 26, 2023
@jacobsalmela jacobsalmela requested a review from a team as a code owner April 26, 2023 16:04
@github-actions
Copy link

github-actions bot commented Apr 26, 2023

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.8.0-20230509111555.4db5097

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.8.0-20230509111555.4db5097

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.8.0-20230509111555.4db5097

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.8.0-20230509111555.4db5097 > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of 94f894d and the PR base branch. Good luck and make rocket go now! 🌮 🚀

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd:2.8.0-20230509111600.4db5097

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd:2.8.0-20230509111600.4db5097

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd:2.8.0-20230509111600.4db5097

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd:2.8.0-20230509111600.4db5097 > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of 94f894d and the PR base branch. Good luck and make rocket go now! 🌮 🚀

Signed-off-by: Jacob Salmela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant