Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-7248: Use apiVersion autoscaling/v2 for HorizontalPodAutoscaler #47

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

studenym-hpe
Copy link
Contributor

Summary and Scope

In preparation for upgrading Kubernetes to 1.32 in CSM 1.7, the HorizontalPodAutoscaler apiVersion has been changed to autoscaling/v2 (which has been available since k8s 1.23) since autoscaling/v2betav2 will no longer be available as of k8s 1.26.

The if-statement to select autoscaling/v2betav2 or autoscaling/v2 in the kubernetes/cray-istio/templates/autoscale.yaml
template does not work using helm on a system per CASMPET-7248.

Issues and Related PRs

Testing

Tested on beau with helm upgrade. You can see the warnings about autoscaling/v2beta2 on rollback.

pit:~/studenym # helm upgrade -n istio-system cray-istio cray-istio-3.0.1-20250116183846+cbf8356.tgz
Release "cray-istio" has been upgraded. Happy Helming!
NAME: cray-istio
LAST DEPLOYED: Thu Jan 16 19:25:06 2025
NAMESPACE: istio-system
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
A Cray-specific Istio chart
pit:~/studenym # helm list -n istio-system
NAME               	NAMESPACE   	REVISION	UPDATED                                	STATUS  	CHART                                  	APP VERSION
cray-istio         	istio-system	2       	2025-01-16 19:25:06.489437476 +0000 UTC	deployed	cray-istio-3.0.1-20250116183846+cbf8356	1.19.10
cray-istio-deploy  	istio-system	1       	2025-01-13 14:30:55.632653297 +0000 UTC	deployed	cray-istio-deploy-2.0.1                	1.19.10
cray-istio-operator	istio-system	1       	2025-01-13 14:30:53.556527841 +0000 UTC	deployed	cray-istio-operator-2.0.0              	1.19.10
pit:~/studenym # helm history -n istio-system cray-istio
REVISION	UPDATED                 	STATUS    	CHART                                  	APP VERSION	DESCRIPTION
1       	Mon Jan 13 14:33:26 2025	superseded	cray-istio-3.0.0                       	1.19.10    	Install complete
2       	Thu Jan 16 19:25:06 2025	deployed  	cray-istio-3.0.1-20250116183846+cbf8356	1.19.10    	Upgrade complete
pit:~/studenym # helm rollback -n istio-system cray-istio 1
W0116 19:41:37.899734    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:37.922915    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:37.961895    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:37.974514    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:37.986042    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.030097    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.051505    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.075605    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.095884    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.107726    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.114586    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
W0116 19:41:38.120408    4522 warnings.go:70] autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler
Rollback was a success! Happy Helming!
pit:~/studenym #

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@studenym-hpe studenym-hpe requested a review from bo-quan January 16, 2025 19:48
@studenym-hpe studenym-hpe marked this pull request as ready for review January 16, 2025 21:59
@studenym-hpe studenym-hpe requested a review from a team as a code owner January 16, 2025 21:59
Copy link

@davidfluck-hpe davidfluck-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@studenym-hpe studenym-hpe merged commit 9daea41 into master Jan 16, 2025
5 checks passed
@studenym-hpe studenym-hpe deleted the CASMPET-7248-autoscaling-v2 branch January 17, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants