-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CMCC 2406.0.1 #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating only references to CoreMedia artifacts, thus, adjusted to most recent 2406.0 release, which is 2406.0.1.
2406.0.1 Dependency Updates
Moving access to `Translation Services` from `GccWorkflowPlugin` to a dedicated class. Refactored the access, so that the due date displayed in the start workflow window, does not get invalidated just because of changes within the path `/Settings/Options/Settings`. Note, that the new code inherits the previous behavior to respect only settings for `Translation Services` at global settings and no site specific ones.
Adapted .gitignore to also ignore settings for IntelliJ Idea and VSCode if loaded as submodule in Blueprint workspace.
One important process for CoreMedia when approving the GlobalLink connector for a new version is to "forward" changes to the ci/develop branch having a minor adaptations applied, so that it runs within the CI. This workflow is meant to assist by automatically updating the corresponding branch.
Fixes access to properties, which also must respect the document level property `settings`. Also changes the "default due date" to some positive number. Using 30 (days) as first guess, that may be a suitable option to take.
docs: Update Third Party Licenses
* Giving up to prevent reloading of Due Date for now. This needs to be fixed as part of the studio-client API. * Ensure, that a zero day offset is considered invalid and thus, any other setting is preferred.
Instead of automatically triggering the update process on push, we take the next MVP step only, which is, to provide a manual action to invoke. This way we can validate the behavior and decide later, if we want to do it automatically.
…issue Fixes For Default Due Date Handling
…tically ci(github): Provide Workflow to Automatically Update ci/develop
CoreMedia Blueprint for CMCC 12.2406.0.01 requires Maven version 3.8.6. Aligned with required version with Blueprint.
refactor(studio-client): Prefer index.ts Imports
rreich
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
I didn't check the studio-client changes in depth.
Just left some minor questions/remarks.
Due to the new versioning scheme, the version of the GlobalLink adapter should be set to v2406.0.1-1. Also, added some more details about applied changes.
docs(changelog): Adapted Version and Details
rreich
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalLink Connect Cloud for CoreMedia Content Cloud v12.2406.0.1
Updated dependencies to CoreMedia Content Cloud v12.2406.0.1 and aligned third-party dependencies.
Improvements 💪
CMCC Update: Updates applied towards CoreMedia Content Cloud v12.2406.0.1.
Prefer index.ts: In Studio Client, where applicable, preferring imports from
index.ts
.Due Date Offset Configuration Hardened: Hardened implementation towards possible mistakes in the configured
globalLink.dayOffsetForDueDate
. To do so, extracted an extra class to manage settings access within Studio Client.Note, that the settings access in Studio Client still only supports global and not site specific settings.
Git Ignore: Updated
.gitignore
to better align with integration as Git submodule.Bug Fixes 🩹
globalLink.dayOffsetForDueDate
, the corresponding value must also be given as positive number. Any non-positive number will be ignored, and a default will be taken instead.Behind the Scenes 🎭
GitHub Actions: Added a GitHub Action for semi-automatic update of the
ci/develop
branch.This action is meant to be triggered automatically on push to
develop
, once it has proven to work smoothly.Shell Scripts: A shell script
sh/update-ci-develop.sh
has been added. While meant to be invoked by the GitHub Action, it may also be run directly by developers to updateci/develop
.