Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(emulated): small perf on doubleAndAdd #1386

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

yelhousni
Copy link
Contributor

Description

smol perf that avoids some emulated subs.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

All current related tests pass.

How has this been benchmarked?

Precompiles (scs):

  • ECRECOVER:
old: 366 181
new: 365 153
  • ECMUL:
old: 221 844
new: 221 280

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added this to the v0.11.N milestone Jan 7, 2025
@yelhousni yelhousni requested a review from ivokub January 7, 2025 20:35
@yelhousni yelhousni self-assigned this Jan 7, 2025
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yelhousni yelhousni merged commit a8eb033 into master Jan 8, 2025
5 checks passed
@yelhousni yelhousni deleted the perf/emulated-dbladd branch January 8, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants