Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: PairingCheck for BN254 and BLS12-381 #1365

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

perf: PairingCheck for BN254 and BLS12-381 #1365

wants to merge 7 commits into from
+607 −17

Conversation

yelhousni
Copy link
Contributor

@yelhousni yelhousni commented Dec 20, 2024 •
edited
Loading

Description

This PR saves the squarings previously needed in AssertFinalExpIsOne for PairingCheck.
See discussion #1347.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

PTestPairingCheckTestSolve tests pass.

How has this been benchmarked?

The PR saves 371,175 scs for BLS12-381 and 238,793 scs for BN254.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the perf label Dec 20, 2024
@yelhousni yelhousni added this to the v0.11.N milestone Dec 20, 2024
@yelhousni yelhousni requested a review from ivokub December 20, 2024 22:00
@yelhousni yelhousni self-assigned this Dec 20, 2024
@yelhousni yelhousni mentioned this pull request Dec 20, 2024
Closed
9 tasks
shramee
shramee approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@shramee shramee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great to me!
Thanks for the great work! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shramee shramee shramee approved these changes

@ivokub ivokub Awaiting requested review from ivokub

At least 1 approving review is required to merge this pull request.

Assignees

@yelhousni yelhousni

Labels
perf
Projects
None yet
Milestone
v0.11.N
Development

Successfully merging this pull request may close these issues.
2 participants
@yelhousni @shramee