-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace input nodes with state nodes receiving observations #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 95.64% 95.39% -0.25%
==========================================
Files 23 22 -1
Lines 1194 1130 -64
==========================================
- Hits 1142 1078 -64
Misses 52 52 ☔ View full report in Codecov by Sentry. |
LegrandNico
changed the title
replace input nodes by observable state nodes
Replace input nodes with state nodes that receive observations
Sep 27, 2024
LegrandNico
changed the title
Replace input nodes with state nodes that receive observations
Replace input nodes with state nodes receiving observations
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove input nodes from the API. All nodes are state nodes that can receive observations or be influenced by other nodes, at each time point. Most of the changes are internal, but this will simplify network construction in the future and come with performance improvements.
This also:
set_update_sequence
fromNetworks
Close #231
Close #221