Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace input nodes with state nodes receiving observations #239

Merged
merged 16 commits into from
Sep 27, 2024
Merged

Conversation

LegrandNico
Copy link
Collaborator

@LegrandNico LegrandNico commented Sep 19, 2024

This PR remove input nodes from the API. All nodes are state nodes that can receive observations or be influenced by other nodes, at each time point. Most of the changes are internal, but this will simplify network construction in the future and come with performance improvements.

This also:

  • Fix the propagation of prediction errors in case of multivariate ascendency.
  • Add better/more relevant examples for multivariate connections.
  • Rewrite the updates for the categorical state node (prediction and prediction errors)
  • Store the time steps in position -1 of the attributes dictionary
  • Allow inputs to receive vector of data, and split predictions and updates in the update sequences
  • Remove the method set_update_sequence from Networks
  • Add a universal observation step

Close #231
Close #221

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.23810% with 15 lines in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (a8d2350) to head (831cd4a).

Files with missing lines Patch % Lines
src/pyhgf/model/network.py 89.09% 6 Missing ⚠️
src/pyhgf/plots.py 88.88% 6 Missing ⚠️
src/pyhgf/utils.py 96.51% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   95.64%   95.39%   -0.25%     
==========================================
  Files          23       22       -1     
  Lines        1194     1130      -64     
==========================================
- Hits         1142     1078      -64     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LegrandNico LegrandNico changed the title replace input nodes by observable state nodes Replace input nodes with state nodes that receive observations Sep 27, 2024
@LegrandNico LegrandNico changed the title Replace input nodes with state nodes that receive observations Replace input nodes with state nodes receiving observations Sep 27, 2024
@LegrandNico LegrandNico merged commit 838f16d into master Sep 27, 2024
5 checks passed
@LegrandNico LegrandNico deleted the inputs branch September 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the Bi/Co notation for input nodes show predictions for continuous input nodes in plot_trajectories
2 participants