Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get-CVClientLicense/Revoke-CVClientLicense function #9

Closed
wants to merge 5 commits into from
Closed

Add Get-CVClientLicense/Revoke-CVClientLicense function #9

wants to merge 5 commits into from

Conversation

CraigTolley
Copy link

Hi,

Have added a new function to specifically get the client licenses. Am working on a counter function to remove client licenses as well.

Hope format is ok. Tried to keep with everything that you have already done.

Craig

@CraigTolley CraigTolley changed the title Add Get-ClientLicense function Add Get-CVClientLicense function Feb 21, 2020
@CraigTolley CraigTolley changed the title Add Get-CVClientLicense function Add Get-CVClientLicense/Revoke-CVClientLicense function Feb 21, 2020
@CraigTolley
Copy link
Author

CraigTolley commented Feb 21, 2020

Provides the license functionality in issue #4

Copy link
Contributor

@gstoops gstoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Craig, great work here. We just need to address a few things. :)
Please push your changes to Commvault.CommCell.psd1 for the new function exports:
FunctionsToExport = @('Get-CVAlert', 'Get-CVClientGroup', 'Get-CVClient', 'Get-CVClientLicense', 'Revoke-CVClientLicense',
'Get-CVSubclient', 'Get-CVVersionInfo', 'Set-CVClient', 'Set-CVClientGroup')

@CraigTolley
Copy link
Author

All suggestions incorporated.

@CraigTolley CraigTolley requested a review from gstoops February 26, 2020 12:54
@CraigTolley
Copy link
Author

Is there anything else that you need me to do before this can get merged in?

New functions to allow disabling of activities on Clients.
New enum CVActivityType to limit options
@CraigTolley
Copy link
Author

Closed as updating my repos and creating a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants