Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for .binlog output in build scripts #170

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Hotfix for .binlog output in build scripts #170

merged 1 commit into from
Feb 20, 2024

Conversation

Arlodotexe
Copy link
Member

No description provided.

@Arlodotexe Arlodotexe added the bug 🐛 Something isn't working label Feb 20, 2024
@Arlodotexe Arlodotexe self-assigned this Feb 20, 2024
@Arlodotexe Arlodotexe enabled auto-merge (rebase) February 20, 2024 19:35
@Arlodotexe Arlodotexe merged commit 58a29be into main Feb 20, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the build-scripts/hotfix/binlog-output branch February 20, 2024 20:55
@michael-hawker
Copy link
Member

From Arlo:

The variable is global and doesn't need to be locally scoped, and it caused issues
Which is odd because I had tested this before submitting the PR
Might have been the version of PowerShell I was using
This avoids the problem entirely instead of mucking with syntax differences across powershell versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arlodotexe @michael-hawker