Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Update Camera Depedancies #2390

Closed
wants to merge 4 commits into from

Conversation

ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix commented Dec 18, 2024

  • Bug fix

Description of Change

  • Update Android Dependancies to version 1.4.1

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Update Android Camera Dependancies.

@ne0rrmatrix ne0rrmatrix added the Camera 📸 Issue/PR associated with the Camera package label Dec 18, 2024
@ne0rrmatrix ne0rrmatrix changed the title Android - Update Camera Depedancies and fix Camera zoom Android - Update Camera Depedancies Dec 18, 2024
@brminnick
Copy link
Collaborator

Do we need to update these NuGet packages for a new feature? It's best practice to keep the dependencies as low and as minimal as possible.

@ne0rrmatrix
Copy link
Contributor Author

The short answer is not today. The long answer is as follows.

As we update to newer versions on maui we will end up with nuget depedancies that will prevent build eventually as Android has build dependancies that will eventually creep in and I am finding that keeping them current if at all possible prevents these issues. We can always keep an open PR for updates to Camera and just push it when Maui depedancies require it for build.

ATM there are issues with libs that will require a an update soon. The issue is currently a build warning as there are unalligned libs that are showing as uknown. Maui has specific android libs compiled by dotnet team into them. They have specific versions of support libs that are common to most other libraries that use them. They must be the same version across all libraries or a very close match. They default to the lowest common denominator of version.

Maui bumps support libs on fairly regular cycle and the team is working on changing the way that is done with support libs. That maybe years out or never. They have a sticky on Android support libs github project and a bot responding automatically for this exact issue. So it is an ongoing issue. It was never relevent for media 2 with mediaelement because we were using a version that was EOL and would never be upgraded.

@brminnick
Copy link
Collaborator

The short answer is not today

Got it - thanks! Let's avoid bumping these NuGet Package dependencies until we are required to avoid breaking dependencies in our user's apps.

@brminnick brminnick closed this Dec 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Camera 📸 Issue/PR associated with the Camera package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants