C;CLCC config menu UI #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PringlesGang
force-pushed
the
cclcc-config-ui
branch
3 times, most recently
from
b8099dd to
178457c
Compare
PringlesGang
force-pushed
the
cclcc-config-ui
branch
2 times, most recently
from
1429654 to
0e5370f
Compare
PringlesGang
force-pushed
the
cclcc-config-ui
branch
2 times, most recently
from
ada7dda to
5be3b53
Compare
PringlesGang
force-pushed
the
cclcc-config-ui
branch
from
2ee9b92 to
0dc85ea
Compare
KKhanhH
requested changes
Jan 3, 2025
KKhanhH
reviewed
Jan 7, 2025
PringlesGang
force-pushed
the
cclcc-config-ui
branch
from
16df35a to
5c19f3c
Compare
KKhanhH
reviewed
Jan 18, 2025
src/games/cclcc/optionsmenu.cpp
Outdated
| constexpr int columns = 3; | ||
| constexpr int entries = 12; | ||
| for (int i = 0; i < entries; i++) { | ||
| glm::vec2 pos = VoicePosition; |
There was a problem hiding this comment.
You're shadowing pos here
There was a problem hiding this comment.
Oh yeah that can just reuse the old pos. Thanks for the heads-up
KKhanhH
reviewed
Jan 18, 2025
src/games/cclcc/optionsmenu.cpp
Outdated
| } | ||
|
|
||
| void OptionsMenu::Render() { | ||
| if (State != Hidden && ScrWork[SW_SYSSUBMENUCT] >= 32 && | ||
| ScrWork[SW_SYSSUBMENUNO] == 5) { | ||
| // glm::vec4 col(1.0f, 1.0f, 1.0f, FadeAnimation.Progress); | ||
| Renderer->DrawSprite(BackgroundSprite, glm::vec2(0.0f)); | ||
| glm::vec4 col(1.0f, 1.0f, 1.0f, FadeAnimation.Progress); |
There was a problem hiding this comment.
Since everything is already being made const, it might not be a bad idea to make col const and maskTint const with const glm::vec4 maskTint = col * glm::vec4{glm::vec3{1}, (float)0xa0 / 0x100}};
PringlesGang
force-pushed
the
cclcc-config-ui
branch
from
9a1c9eb to
b471ab0
Compare
KKhanhH
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will implement the UI for the C;CLCC config menu
(Will do the actual implementation in a separate PR once this is done)