Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow minimizing main window from taskbar #315

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Allow minimizing main window from taskbar #315

merged 1 commit into from
Nov 25, 2023

Conversation

shatyuka
Copy link
Contributor

Remove the "ReunionCaptionControlsWindow" window to hide the control buttons.

Fix #311

@shatyuka shatyuka self-assigned this Nov 25, 2023
@bagusnl
Copy link
Member

bagusnl commented Nov 25, 2023

Will do check on published package to make sure nothing weird happens

@bagusnl bagusnl requested a review from a team November 25, 2023 02:50
@bagusnl bagusnl added Bug Something isn't working Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse labels Nov 25, 2023
@bagusnl
Copy link
Member

bagusnl commented Nov 25, 2023

Published package testing is done, works as espected.

bagusnl
bagusnl approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Merging by rebase
oozora-subaru-hololive

Thank you for your work~

@bagusnl bagusnl merged commit de9687d into CollapseLauncher:main Nov 25, 2023
1 check passed
@neon-nyan neon-nyan added this to the v1.72.x milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagusnl bagusnl bagusnl approved these changes

Assignees

@shatyuka shatyuka

Labels
Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse Bug Something isn't working
Projects
None yet
Milestone
v1.72.x
Development

Successfully merging this pull request may close these issues.

[Request]: Add the ability to minimize Collapse by clicking taskbar icon
3 participants
@shatyuka @bagusnl @neon-nyan