Navigator: Allow text list items to wrap #10936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the text gets cropped and impossible to read. This commit also fixes or decreases the image diff in cypress test fail on "writer/navigator_spec.js" due to Visual Regression Plugin detecting a image mismatch. - make -C cypress_test run-desktop spec=writer/navigator_spec.js Signed-off-by: Pedro Pinto Silva <[email protected]> Change-Id: I4c90b6296b9d4b47490e7a46d8578c5485909b61
|
I originally found the problem in #10896 (comment) |
Darshan-upadhyay1110
approved these changes
Jan 15, 2025
Darshan-upadhyay1110
deleted the
private/pedro/fix-navigator-not-wrapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the text gets cropped and impossible to read.
This commit also fixes or decreases the image diff in cypress test fail on "writer/navigator_spec.js" due to Visual Regression Plugin detecting a image mismatch.
Change-Id: I4c90b6296b9d4b47490e7a46d8578c5485909b61
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay