grooming code #484
grooming code #484
Conversation
|
👷 Deploy request for upswyng pending review. 🔨 Explore the source changes: 3eae401 |
amites
requested review from
jacobvenable,
jollyjerr and
rhinodavid
as code owners
There was a problem hiding this comment.
Looks like an import got messed up somewhere. This is also a lot to test - what if we break apart the "small" stuff (typos and stuff) from the bigger stuff like adding awaits and deleting larger chunks of code. We want to make sure that everything behaves exactly as it is - and we don't really have a lot of resources to do a full regression test right now 😅. I love what is going on in here but I think taking it in smaller steps might be best? Jacob may disagree though and that's totally fair - I'm good with anything!
|
removed all the logic changes adding added a bunch of comments to help simplify review -- let me know if ya need to break this down further |
jollyjerr
dismissed
their stale review
Will take another look as soon as I get a chance!
This PR closes n/a
What does this PR do?
Grooming code structure while creating docs
How does this PR make you feel? 🔗
![good]