Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

add in this line to update sources #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmeluski
Copy link

@gmeluski gmeluski commented Jun 18, 2019

I was getting an error when running docker-compose build:

W: Failed to fetch http://deb.debian.org/debian/dists/jessie-updates/InRelease  Unable to find expected entry 'main/binary-amd64/Packages' in Release file (Wrong sources.list entry or malformed file)

Submitting a change to the Dockerfile based upon this info: https://superuser.com/a/1423685

@kmcurry kmcurry requested a review from BretFisher June 19, 2019 00:13
@BretFisher
Copy link
Member

Thanks @gmeluski but the core issue here is the base ruby image is outdated, thus the package installs fail. I'm trying to test with the latest ruby release to see if we can just update the base instead.

@BretFisher
Copy link
Member

BretFisher commented Jun 19, 2019

Hey @gmeluski can you try updating to ruby 2.3.8 rather than your current solution and see if it builds?

You'll need to update the version line in Dockerfile and Gemfile

diff --git a/Dockerfile b/Dockerfile
index 10ca5ec..69dbc6d 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM ruby:2.3.5
+FROM ruby:2.3.8

 RUN apt-get update -qq && apt-get install -y build-essential libpq-dev nodejs

diff --git a/Gemfile b/Gemfile
index 925e56f..487d853 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-ruby '2.3.5'
+ruby '2.3.8'

 gem 'devise', '~> 3.0'
 gem 'geokit', '~> 1.0'```

@kmcurry
Copy link
Member

kmcurry commented Jun 20, 2019

@BretFisher @gmeluski should this PR be submitted to develop and promoted to master?

@BretFisher
Copy link
Member

Yes. @gmeluski we have a develop (staging) environment and branch to test changes. Can you close this PR, open a new one to develop, and test my suggested ruby version changes rather then apt change? Thanks for the help!

@BretFisher BretFisher removed their request for review January 14, 2022 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants