Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build failed when registry address with port #47

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

chlins
Copy link
Contributor

@chlins chlins commented Dec 17, 2024

Fixes: #46

This pull request includes various fixes and improvements across multiple files in the pkg/backend and pkg/storage directories. The changes mainly focus on correcting typos, ensuring proper error handling, and updating import statements for better code organization.

Typo Fixes:

  • Corrected typos in error messages within the Build and Extract methods in pkg/backend/build.go and pkg/backend/extract.go respectively. [1] [2]

Error Handling Improvements:

  • Updated error handling in the Process method for multiple processors (licenseProcessor, modelProcessor, modelConfigProcessor, and readmeProcessor) to return the actual error instead of nil in case of a failure. [1] [2] [3] [4]

Import Statement Updates:

  • Reorganized import statements in pkg/backend/processor/license.go, pkg/backend/processor/model.go, pkg/backend/processor/model_config.go, and pkg/backend/processor/readme.go to maintain consistency and readability. [1] [2] [3] [4]

New Functionality:

  • Added an initialization function in pkg/storage/distribution/distribution.go to modify the PathRegexp to support repository names that include a port.

Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 9fd48f9 into main Dec 17, 2024
5 checks passed
@gaius-qi gaius-qi deleted the fix/registry-address-with-port branch December 17, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modctl failed to handle repository path with ports
2 participants