fix: add plain-http option for login cmd #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
cmd/login.go
andpkg/backend
files to replace theInsecure
flag with a newPlainHTTP
flag for allowing HTTP connections to the registry. Additionally, the backend login function has been modified to accept options.Changes to
cmd/login.go
:PlainHTTP
flag.Insecure
flag with thePlainHTTP
flag in the command initialization.runLogin
function to handle the newPlainHTTP
flag using backend options.Changes to
pkg/backend
:Login
method signature in theBackend
interface to accept options instead of theinsecure
boolean.Login
method implementation to apply the new options and handle thePlainHTTP
flag accordingly. [1] [2]Changes to
pkg/config/login.go
:Insecure
field with thePlainHTTP
field in theLogin
struct and its constructor.