Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add plain-http option for login cmd #28

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: add plain-http option for login cmd #28

merged 1 commit into from
Nov 20, 2024

Conversation

chlins
Copy link
Contributor

@chlins chlins commented Nov 20, 2024

This pull request includes several changes to the cmd/login.go and pkg/backend files to replace the Insecure flag with a new PlainHTTP flag for allowing HTTP connections to the registry. Additionally, the backend login function has been modified to accept options.

Changes to cmd/login.go:

  • Updated the login command description to reflect the new PlainHTTP flag.
  • Replaced the Insecure flag with the PlainHTTP flag in the command initialization.
  • Modified the runLogin function to handle the new PlainHTTP flag using backend options.

Changes to pkg/backend:

  • Updated the Login method signature in the Backend interface to accept options instead of the insecure boolean.
  • Modified the Login method implementation to apply the new options and handle the PlainHTTP flag accordingly. [1] [2]

Changes to pkg/config/login.go:

  • Replaced the Insecure field with the PlainHTTP field in the Login struct and its constructor.

Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit a8d279a into main Nov 20, 2024
3 checks passed
@gaius-qi gaius-qi deleted the fix/http-login branch November 21, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants