-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDO-2649] Kubernetes Optimizer Project #103
Closed
Closed
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
5a066d0
Add Controller Helm chart and add it as dependency
gm-cht 8bce2f2
Dependent helm chart optinal
gm-cht 19f325b
Configure CronJob
gm-cht acb0230
Add CRD permissions
gm-cht 1b0cb7c
Change image name
gm-cht 02ef1d3
Update version to get a new chart
gm-cht 6cb0cff
Add chapi token as secret
gm-cht fc44d64
Move to including the built chart as dependency.
gm-cht 411d2c8
add cron schedule
gm-cht db51661
Update tgz file dependency path
gm-cht f0c4bb9
Fix helm
gm-cht 423821f
Update Chart version
gm-cht efa7ceb
revert change to release.yml
gm-cht 60193dc
Some fixes
gm-cht 197d433
package controller helm
gm-cht f50700e
Add helm chart instead of tgz file
gm-cht fa8fd4a
Fix image repo and name of controller
gm-cht 8eb061a
Update gitignore and github actions
gm-cht 7c60635
Add new commands to Notes
gm-cht b593ab1
Re-add github action for this branch
gm-cht 31a55fe
Update version to get PR build passing
gm-cht 7ddb78e
Fix version number of controller image
gm-cht d2dd2c9
Fix Cron Job
gm-cht 8e02f86
Fix parameter name
gm-cht 5b09c25
Add Spring Profile parameter
gm-cht 187af4d
Update controller image registry
gm-cht bbe43fc
Update path of controller helm chart. Remove subchart
gm-cht 7292c25
Update controller version
gm-cht 3867720
Generate correct 5.1.0-alpha chart
gm-cht da4f915
5.1.1-alpha chart
gm-cht c58b4f2
Regenrate helm for 0.2.0 controller
gm-cht 5ba759a
Generate helm for 1.0.0-beta version of controller
gm-cht 53ddb2c
5.1.0-alpha for 0.2.0-beta controller
gm-cht 824bb38
5.2.0-alpha for 1.0.0-beta version of controller
gm-cht 8c3b593
chapiToken to chapiKey.
gm-cht 1b29659
Better name for cronJob pod
gm-cht 7fa3c48
Add ClusterRole. Fix some yaml syntax issues in values.yaml
gm-cht 3972a60
Fixed YAML syntax on values.yaml
gm-cht cbbddaa
Add Getting CRDs permission
gm-cht 1b41fcf
Add create permissions to serviceAccount. Also make these permissions…
gm-cht de7e6b7
Squashed commit of the following:
gm-cht 4500812
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht a43249e
Fixes due to merge
gm-cht 8247611
Fix english
gm-cht 485fae9
Move registry to `kubernetes-optimization`
gm-cht 988a36e
Remove Image tags from being overridden in main chart
gm-cht b2fc51f
Change imagePullPolicy
gm-cht 9c18deb
Update permissions
gm-cht 14c2074
Set default requests and limits for optimizer agent.
gm-cht 1c21afc
Beta Version release
gm-cht e76377a
Fix ReadMe
gm-cht 64854f6
Fixed Notes
gm-cht 13d9428
Minor Chart version change
gm-cht 03c2529
Add better checks for cluster_name
gm-cht 6253cd7
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht b7337cd
Change clusterName check to minimum 3 characters and minInterval to 1…
gm-cht 3b47c17
Update Optimization controller to 1.0.2-beta
gm-cht d13e30f
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht 6160189
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht 741386b
k8s-optimizer-1.0.0-beta
gm-cht 80d20df
Fix optimizer version to 1.1.0
gm-cht e785c9e
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht cb826cf
Hardcode Optimizer Agent Image to 1.0.0-18
gm-cht d052fc2
Update Optimizer Agent to 1.0.0-19
gm-cht 1e87155
Update to Controller 1.1.1 & Increase CPU/Mem of optimizer and Contro…
gm-cht b630e7c
Update Optimizer Agent to 1.0.0-20 (#115)
kscherme 3951fd3
Merge branch 'main' into gmudumbai/sdo-2649-k8s-optimizer
gm-cht 23f17f9
[SDO-2961] Update controller dependency to JFrog repo (#120)
kscherme 92790c6
set branch releases as not latest
kscherme a08a3b4
update releaser version
kscherme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ name: Release Charts | |
on: | ||
push: | ||
branches: | ||
- main | ||
- gmudumbai/sdo-2649-k8s-optimizer | ||
|
||
jobs: | ||
release: | ||
|
@@ -22,6 +22,8 @@ jobs: | |
git config user.name "$GITHUB_ACTOR" | ||
git config user.email "[email protected]" | ||
- name: Run chart-releaser | ||
uses: helm/[email protected] | ||
uses: helm/[email protected] | ||
with: | ||
mark_as_latest: false | ||
env: | ||
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
charts/cloudhealth-collector/templates/optimizer-agent-cron.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
{{- /* | ||
Copyright 2023 VMware, Inc. | ||
SPDX-License-Identifier: Apache-2.0 | ||
*/}} | ||
|
||
{{- if .Values.optimizer.enabled }} | ||
apiVersion: batch/v1 | ||
kind: CronJob | ||
metadata: | ||
name: {{ include "cloudhealth-optimizer-agent.name" . }} | ||
labels: | ||
{{- include "cloudhealth-collector.labels" . | nindent 4 }} | ||
{{- with .Values.deployAnnotations }} | ||
annotations: | ||
{{- toYaml . | nindent 4 }} | ||
{{- end }} | ||
spec: | ||
schedule: "0 12 * * *" | ||
jobTemplate: | ||
spec: | ||
template: | ||
spec: | ||
serviceAccountName: {{ include "cloudhealth-collector.serviceAccountName" . }} | ||
containers: | ||
- name: {{ include "cloudhealth-optimizer-agent.name" . }} | ||
env: | ||
- name: CHAPI_KEY | ||
valueFrom: | ||
secretKeyRef: | ||
name: {{ include "cloudhealth-collector.secretName" . }} | ||
key: chapiKey | ||
- name: CHT_CLUSTER_NAME | ||
value: {{.Values.clusterName | required "A valid clusterName is required!" | quote }} | ||
- name: CHT_ENDPOINT_PREFIX | ||
value: {{.Values.chtEndpointPrefix | default "use1" }} | ||
- name: SPRING_PROFILES_ACTIVE | ||
value: {{.Values.optimizer.springProfile | default "prod" }} | ||
image: "{{ .Values.optimizer.image.repository }}:{{ .Values.optimizer.image.tag | default "latest" }}" | ||
imagePullPolicy: {{ .Values.optimizer.image.pullPolicy }} | ||
resources: | ||
{{- toYaml .Values.optimizer.resources | nindent 14 }} | ||
|
||
{{- with .Values.nodeSelector }} | ||
nodeSelector: | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
{{- with .Values.affinity }} | ||
affinity: | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
{{- with .Values.tolerations }} | ||
tolerations: | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
restartPolicy: OnFailure | ||
{{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the name change now (to something like
cloudhealth-collector-and-optimizer
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not change this to keep the workflow and instructions the same for customers who are using only collector.
If and when we change this:
since the repo itself is called
cloudhealth
i prefer changing the helm chart tokubernetes-collector
.I prefer this command:
helm install kubernetes-collector .... cloudhealth/kubernetes-collector
tohelm install cloudhealth-collector ....... cloudhealth/cloudhealth-collector
.Don't think we want to change the helm chart name without a wider discussion and announcement. Having
optimizer
in the name might also warrant discussion given most of our customers will be collector only customers.