-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove windows #233
base: master
Are you sure you want to change the base?
ci: remove windows #233
Conversation
The FDB community is officially discontinuing the Windows build (see apple/foundationdb#5135 for more info). We cannot download msi packages as they were removed from official sites. As the `windows-latest` is mandatory for any PR, this commit is removing the `windows-latest` from Github actions. We may add it back later to use community build.
1ccfaec
to
63d6a93
Compare
Mmmh, I can see some errors related to clap. Clap's MSRV for >=3.0 is 1.54.0, should we bump? Also, we are targetting |
bindingtester is only "in tree" so we probably don't have to care about MSRV. |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 76.58% 79.88% +3.30%
==========================================
Files 18 18
Lines 3041 3038 -3
==========================================
+ Hits 2329 2427 +98
+ Misses 712 611 -101
Continue to review full report at Codecov.
|
but CI has (in the current configuration) to run with 1.40... |
* structopt * clang-sys
e9bc9a8
to
54c76d2
Compare
CI is green on my side, but I had to bump the MSRV to fix it, |
The FDB community is officially discontinuing the Windows build (see
apple/foundationdb#5135 for more info). We cannot download msi packages
as they were removed from official sites.
As the
windows-latest
is mandatory for any PR, this commit is removingthe
windows-latest
from Github actions. We may add it back later touse community build.