Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove windows #233

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

PierreZ
Copy link

@PierreZ PierreZ commented Jul 9, 2021

The FDB community is officially discontinuing the Windows build (see
apple/foundationdb#5135 for more info). We cannot download msi packages
as they were removed from official sites.

As the windows-latest is mandatory for any PR, this commit is removing
the windows-latest from Github actions. We may add it back later to
use community build.

The FDB community is officially discontinuing the Windows build (see
apple/foundationdb#5135 for more info). We cannot download msi packages
as they were removed from official sites.

As the `windows-latest` is mandatory for any PR, this commit is removing
the `windows-latest` from Github actions. We may add it back later to
use community build.
@PierreZ PierreZ force-pushed the dev/remove-windows branch from 1ccfaec to 63d6a93 Compare July 9, 2021 10:22
@PierreZ
Copy link
Author

PierreZ commented Aug 16, 2021

Mmmh, I can see some errors related to clap. Clap's MSRV for >=3.0 is 1.54.0, should we bump?

Also, we are targetting structopt = "0.3.3" which does not exists, latest is 0.3.22.

@Speedy37
Copy link
Contributor

bindingtester is only "in tree" so we probably don't have to care about MSRV.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 70.049% when pulling 23dc27d on PierreZ:dev/remove-windows into f41fa13 on Clikengo:master.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #233 (23dc27d) into master (f41fa13) will increase coverage by 3.30%.
The diff coverage is n/a.

❗ Current head 23dc27d differs from pull request most recent head 54c76d2. Consider uploading reports for the commit 54c76d2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   76.58%   79.88%   +3.30%     
==========================================
  Files          18       18              
  Lines        3041     3038       -3     
==========================================
+ Hits         2329     2427      +98     
+ Misses        712      611     -101     
Impacted Files Coverage Δ
foundationdb-gen/src/lib.rs 0.42% <0.00%> (+<0.01%) ⬆️
foundationdb/src/tuple/mod.rs 89.78% <0.00%> (+0.86%) ⬆️
foundationdb-bindingtester/src/main.rs 90.24% <0.00%> (+1.55%) ⬆️
foundationdb/src/tuple/pack.rs 90.42% <0.00%> (+2.68%) ⬆️
foundationdb/src/api.rs 87.50% <0.00%> (+3.93%) ⬆️
foundationdb/src/tuple/element.rs 63.69% <0.00%> (+4.10%) ⬆️
foundationdb/src/future.rs 90.71% <0.00%> (+4.91%) ⬆️
foundationdb/src/database.rs 72.82% <0.00%> (+6.52%) ⬆️
foundationdb/src/transaction.rs 87.24% <0.00%> (+11.72%) ⬆️
foundationdb/src/tuple/versionstamp.rs 66.66% <0.00%> (+11.90%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41fa13...54c76d2. Read the comment docs.

@Speedy37
Copy link
Contributor

but CI has (in the current configuration) to run with 1.40...

@PierreZ
Copy link
Author

PierreZ commented Sep 27, 2021

CI is green on my side, but I had to bump the MSRV to fix it, clang-sys's transitives dependencies requires 1.46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants