Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logback and offer structured logging options #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n-oden
Copy link

@n-oden n-oden commented Oct 13, 2022

  • install logback-classic and exclude conflicting transitive dependencies in pom.xml

  • add a default logback.xml file

  • update the README to link to the logback documentation and point out how and where to enable structured logging

  • add test.Dockerfile to build a deployable docker image from a locally built fatjar

- install logback-classic and exclude conflicting transitive
  dependencies in pom.xml

- add a default logback.xml file

- update the README to link to the logback documentation and point
  out how and where to enable structured logging

- add `test.Dockerfile` to build a deployable docker image from
  a locally built fatjar
@zhicwu
Copy link
Contributor

zhicwu commented Oct 14, 2022

Thanks for your contribution @n-oden. JDBC bridge is not actively maintained on server side, so I'd suggest you using another table function like url instead. I'll find time to implement a new module in clickhouse-jdbc repo to retire this one.

@n-oden
Copy link
Author

n-oden commented Oct 14, 2022

Thanks for your contribution @n-oden. JDBC bridge is not actively maintained on server side, so I'd suggest you using another table function like url instead. I'll find time to implement a new module in clickhouse-jdbc repo to retire this one.

Oh, oops. You might want to mark this repo as archived then to keep people away from it. I'll take a quick look at the clickhouse-JDBC repo and see if it's difficult to port this change over to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants