-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesoscale Simulations in Library #133
base: main
Are you sure you want to change the base?
Conversation
Tentative to-do list
|
Do you mind if I commit to this PR? TODO:
|
…brary.jl into xr-as-nc/mesoscale_simulations
…liMA/LESbrary.jl into xr-as-nc/mesoscale_simulations
…liMA/LESbrary.jl into xr-as-nc/mesoscale_simulations
@@ -218,9 +218,8 @@ function eddying_channel_simulation(; | |||
simulation = Simulation(model; Δt=initial_Δt, stop_time) | |||
|
|||
# add timestep wizard callback | |||
wizard = TimeStepWizard(; cfl = 0.1, max_change = 1.01, max_Δt) | |||
wizard = TimeStepWizard(; cfl = 0.2, max_change = 1.01, max_Δt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_change = 1.01
?
Is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's helpful when experimenting with very small initial time-steps for CATKE
@@ -27,8 +27,6 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | |||
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
|
|||
[compat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[compat] | |
[compat] | |
Oceananigans = "0.73.2" |
why not?
A few results. I added biharmonic dissipation and removed the Laplacian diffusion, which wasn't having any effect (dissipation was dominated by WENO I guess). With a coefficient Constrast this with a bit noisier. With a biharmonic coefficient |
Ok, I've also implemented an initial buoyancy distribution that matches the relaxation profile. Here's what we get after a year with The simulations also complete faster because we don't get large vertical velocities early on, perhaps because the initial turbulent motions are a bit larger scale? |
Note: we'll have to implement some tracer forcing if we want it to be useful for this equilibrated case. Something for the future. |
Increase default bottom drag for eddying channel simulation
…liMA/LESbrary.jl into xr-as-nc/mesoscale_simulations
@@ -17,7 +17,7 @@ Random.seed!(1234) | |||
arch = GPU() | |||
with_ridge = false | |||
|
|||
filename = "new_simulation" | |||
filename = "please_dont_crash" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-O
This PR adds idealized mesoscale resolving zonally re-entrant channels to the library. The first stage is to define a function whose input is a few control parameters and whose output can be used for informing parameterization development. There are two main classes of simulations being added: flat bottom and hilly