Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 comparison with momepy #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

vanlankveldthijs
Copy link
Collaborator

Resolves #2

Added some scripts to compare rcoins strokes to momepy.COINS strokes and a gitHub action to run this comparison on pull request.

There are two scripts

  1. R script to read the Bucharest data set, run rcoins stroke on its streets, and save both input and output to a geopandas package.
  2. python pytest script to read the geopandas package, run momepy.COINS stroke on its streets, and compare the output to the stored rcoins output.

The gitHub action was tested on a fork of rcoins and runs correctly to completion there.

Copy link
Contributor

@fnattino fnattino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vanlankveldthijs for automating this, looks good to me!

Could you please add a line to the changelog (NEWS.md file) with a very brief description of this contribution (one sentence) ?

Apart of this I only have a very minor suggestion (new line at end of file). Thanks again!

scripts/compare_momepy/prepare-test-stroke.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison with momepy
2 participants