Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Django 5.0 #1035

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Update to Django 5.0 #1035

merged 5 commits into from
Mar 4, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Jan 2, 2024 •
edited
Loading

🛠️ Changelog

  • Updates Django to 5.0 release.
    • Required to backport PickleSerializer, as it was removed due to security issues. django-helusers still requires it.

🧪 Test plan

  • Automated tests

🎫 Tickets

  • TILA-####

@matti-lamppu
Copy link
Collaborator Author

matti-lamppu commented Jan 2, 2024 •
edited
Loading

@vergama Here is the situation for updating to the latest major version of Django. Some small things were removed/changed, and one package we use doesn't yet support it (needed to use a lower version). Should we update, or wait until this is fixed?

@vergama
Copy link

vergama commented Jan 3, 2024

Need to get the pending features to production anyway, so can at least wait a little while. Looks like a new version of django-celery-beat just might be coming in the near future. But let's say, if it doesn't happen in the next few weeks then we'll go forward without it by the downgrade route.

@matti-lamppu matti-lamppu force-pushed the update-django branch 2 times, most recently from b8352d7 to 2b18c73 Compare January 11, 2024 09:23
@matti-lamppu matti-lamppu marked this pull request as ready for review January 22, 2024 11:53
@matti-lamppu matti-lamppu requested review from vergama and ranta January 22, 2024 11:53
@matti-lamppu
Copy link
Collaborator Author

I suppose this ticket should be reconsidered now that the major changes to prod are done.

@vergama
Copy link

vergama commented Jan 22, 2024

There seems to be something happening on django-celery-beat too

@cclauss
Copy link

cclauss commented Jan 23, 2024 •
edited
Loading

celery/django-celery-beat#680 (comment) still needs a release to PyPI.

Django-celery-beat v2.6.0 was released…

@matti-lamppu matti-lamppu force-pushed the update-django branch 2 times, most recently from 2d16f9d to 31ba59c Compare February 5, 2024 14:07
@matti-lamppu matti-lamppu added refactor Refactors something dependencies Updates a dependency labels Feb 21, 2024
@matti-lamppu matti-lamppu self-assigned this Feb 22, 2024
MrThearMan and others added 4 commits March 4, 2024 08:38
@MrThearMan @matti-lamppu
Update to Django 5.0
877beca
@matti-lamppu
Add PickleSerializer back from django 4.2
621c356 
django-helusers still requires this
@matti-lamppu
Change some test fixtures to support django 5.0
8778bf5
@matti-lamppu
Update dependencies and make them strict
58c74bf 
Dependabot handles updates anyway, and this way it's more clear
which dependencies should be installed.
@matti-lamppu
Copy link
Collaborator Author

This should be good to go now with django-celery-beat v2.6.0 released. @vergama @ranta

ranta
ranta approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@ranta ranta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop django-prometheus from the dependencies, as all things that previously used it have now been removed

@matti-lamppu
Update dependencies and make them strict
56ffc4d 
Dependabot handles updates anyway, and this way it's more clear
which dependencies should be installed.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matti-lamppu matti-lamppu merged commit dfb3ef7 into main Mar 4, 2024
5 checks passed
@matti-lamppu matti-lamppu deleted the update-django branch March 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama Awaiting requested review from vergama

Assignees

@matti-lamppu matti-lamppu

Labels
dependencies Updates a dependency refactor Refactors something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matti-lamppu @vergama @cclauss @ranta @MrThearMan