Support for all network and vrf configs #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewiebe
reviewed
Mar 10, 2023
mikewiebe
reviewed
Mar 10, 2023
mikewiebe
reviewed
Mar 10, 2023
This was referenced Mar 10, 2023
|
@praveenramoorthy This issue was raised #207. I am wondering if the updates in this PR prevent this from happening. Can you verify? |
mikewiebe
requested changes
Mar 10, 2023
| @@ -65,6 +65,10 @@ | |||
| - '"{{ ansible_switch2 }}" in result.diff[0].attach[1].ip_address' | |||
| - 'result.diff[0].vrf_name == "ansible-vrf-int1"' | |||
|
|
|||
| - name: MERGED - sleep for 40 seconds for DCNM to completely update the state | |||
There was a problem hiding this comment.
Here and elsewhere, let's try and avoid arbitrary sleep statements like this and instead use the following approach:
There was a problem hiding this comment.
Better to check for a specific condition and loop until that condition is reached instead of hoping 40 seconds is long enough. Also if we reach the state sooner then we move to the next task more quickly.
There was a problem hiding this comment.
Changes done as suggested
mikewiebe
approved these changes
Mar 14, 2023
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for all network and vrf configs
Fix for issue in #185 and #197