fix: moderator can delete the forum thread & post #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tachyons
reviewed
Jul 28, 2024
Waishnav
force-pushed
the
fix-admin-delete
branch
from
90f2a33 to
f369a21
Compare
|
@Waishnav Could you update this on main repo and open a PR ? |
what do you I have to update in the main cv codebase? |
|
Update the gem version
…On Tue, 30 Jul, 2024, 5:24 pm Vaishnav Deore, ***@***.***> wrote:
@Waishnav <https://github.com/Waishnav> Could you update this on main
repo and open a PR ?
what do you I have to update in the main cv codebase?
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYAEBAEKJAILP2DU63CXTZO55HXAVCNFSM6AAAAABLS5GMSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYGE3DQOJTHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
since in the Gemfile we have following line, It will just update the Gemfile.lock after update, isn't it will be updated by dependabot ig? gem "simple_discussion", github: "CircuitVerse/simple_discussion" |
|
Dependabot is currently blocked due to vite and other breaking changes, you
need to do that manually
…On Tue, 30 Jul, 2024, 11:27 pm Vaishnav Deore, ***@***.***> wrote:
Update the gem version
since in the Gemfile we have following line, It will just update the
Gemfile.lock after update, isn't it will be updated by dependabot ig?
gem "simple_discussion", github: "CircuitVerse/simple_discussion"
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXYAECYWFXUFI3TE5W2GS3ZO7H2JAVCNFSM6AAAAABLS5GMSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYHEYDGNZUHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
ohh alright, I just raised it. Please have a look CircuitVerse/CircuitVerse#5031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17 following two issues