-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor : typescript integration : src/simulator/src/data.ts #435
Open
ThatDeparted2061
wants to merge
2
commits into
CircuitVerse:main
Choose a base branch
from
ThatDeparted2061:data.ts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−58
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
import Vue from 'vue'; | ||
import { fullView } from './ux'; | ||
import { createSubCircuitPrompt } from './subcircuit'; | ||
import save from './data/save'; | ||
import load from './data/load'; | ||
import createSaveAsImgPrompt from './data/saveImage'; | ||
import { | ||
clearProject, | ||
newProject, | ||
saveOffline, | ||
openOffline, | ||
recoverProject, | ||
} from './data/project'; | ||
import { createNewCircuitScope } from './circuit'; | ||
import { createCombinationalAnalysisPrompt } from './combinationalAnalysis'; | ||
import { colorThemes } from './themer/themer'; | ||
import { showTourGuide } from './tutorials'; | ||
import { createVerilogCircuit } from './Verilog2CV'; | ||
import { generateVerilog } from './verilog'; | ||
import { bitConverterDialog } from './utils'; | ||
import keyBinder from '#/components/DialogBox/CustomShortcut.vue'; | ||
import ExportProject from '#/components/DialogBox/ExportProject.vue'; | ||
import ImportProject from '#/components/DialogBox/ImportProject.vue'; | ||
|
||
interface LogixFunction { | ||
save: typeof save; | ||
load: typeof load; | ||
createSaveAsImgPrompt: typeof createSaveAsImgPrompt; | ||
clearProject: typeof clearProject; | ||
newProject: typeof newProject; | ||
saveOffline: typeof saveOffline; | ||
createOpenLocalPrompt: typeof openOffline; | ||
recoverProject: typeof recoverProject; | ||
createSubCircuitPrompt: typeof createSubCircuitPrompt; | ||
createCombinationalAnalysisPrompt: typeof createCombinationalAnalysisPrompt; | ||
fullViewOption: typeof fullView; | ||
colorThemes: typeof colorThemes; | ||
showTourGuide: typeof showTourGuideHelper; | ||
newVerilogModule: typeof createVerilogCircuit; | ||
generateVerilog: typeof generateVerilog; | ||
bitconverter: typeof bitConverterDialog; | ||
createNewCircuitScope: typeof createNewCircuitScope; | ||
customShortcut: typeof keyBinder; | ||
ExportProject: typeof ExportProject; | ||
ImportProject: typeof ImportProject; | ||
} | ||
|
||
const logixFunction: LogixFunction = { | ||
save, | ||
load, | ||
createSaveAsImgPrompt, | ||
clearProject, | ||
newProject, | ||
saveOffline, | ||
createOpenLocalPrompt: openOffline, | ||
recoverProject, | ||
createSubCircuitPrompt, | ||
createCombinationalAnalysisPrompt, | ||
fullViewOption: fullView, | ||
colorThemes, | ||
showTourGuide: showTourGuideHelper, | ||
newVerilogModule: createVerilogCircuit, | ||
generateVerilog, | ||
bitconverter: bitConverterDialog, | ||
createNewCircuitScope, | ||
customShortcut: keyBinder, | ||
ExportProject, | ||
ImportProject, | ||
}; | ||
|
||
export default logixFunction; | ||
|
||
/** | ||
* Initializes the tour guide with a slight delay to ensure DOM is ready. | ||
* @todo Refactor to use proper lifecycle hooks or event-based initialization | ||
*/ | ||
function showTourGuideHelper(): void { | ||
// Consider using Vue's nextTick or proper event listeners | ||
Vue.nextTick(() => { | ||
showTourGuide(); | ||
}); | ||
} | ||
|
||
// Hack to call createNewCircuitScope with keyboard shortcut | ||
function createNewCircuit(): void { | ||
createNewCircuitScope(); | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove unnecessary wrapper function.
The
createNewCircuit
function is a simple wrapper that adds no value and is explicitly marked as a hack. Consider:createNewCircuitScope
directly for keyboard shortcuts