Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POSIX Compatibility issue '[[' and Refactor Font installations step. #75

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

RazoBeckett
Copy link
Contributor

  1. Update Font Installation Process:
  • Updated the font URL for FiraCode from version 2.3.3 to 3.2.1.
  • Added a check to verify the accessibility of the font URL before attempting to download.
  • Improved the installation process by using a temporary directory to handle downloaded files.
  1. Replaced [[ ... ]] with [ ... ] in the conditional statement for dnf package manager detection.

@manishjchoudhary
Copy link

a77df1e can fix issue #77.
But as I saw in another issue where someone mentioned not seeing the icons correctly #65, people still have to go and change either the terminal / global font so, why install a random Nerd font at all?
Why not do as I mentioned here. Thoughts?

@RazoBeckett
Copy link
Contributor Author

RazoBeckett commented Aug 12, 2024

Hey @manishjchoudhary , the thing is, this process is meant to be automated. Asking the user to visit a website and manually install the font requires effort. Users need to set the font manually for their terminal since everyone has their own preferences. You might prefer using Kitty, while I might be on Alacritty.

change font FiraCode -> Meslo .. and add check if the link can be accessed or not this will stop breaking the script
display only progress while downloading.
@RazoBeckett RazoBeckett changed the title Fix POSIX Compatibility and Update Font Installation in setup.sh Fix POSIX Compatibility issue '[[' and Refactor Font installations step. Aug 13, 2024
@ChrisTitusTech ChrisTitusTech merged commit db983d3 into ChrisTitusTech:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants