Skip to content

Commit

Permalink
Update build flags to remove unused warnings
Browse files Browse the repository at this point in the history
This change updates the CMAKE_CXX_FLAGS in CMakeLists.txt-macos to
remove the -Wunused flag. This flag was causing unused warnings to be
raised during the build process, potentially leading to false positives
and unnecessary noise. By removing the flag, the build process becomes
cleaner and easier to interpret.
  • Loading branch information
ChinChangYang committed Nov 25, 2023
1 parent 2b378c4 commit 367d2c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt-macos
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ message(STATUS "Setting up build for AppleClang.")
target_link_libraries(katago KataGoSwift)
find_package (Threads REQUIRED)
target_link_libraries(katago Threads::Threads)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O2 -pedantic -Wall -Wextra -Wno-sign-compare -Wcast-align -Wcast-qual -Wctor-dtor-privacy -Wdisabled-optimization -Wformat=2 -Wmissing-declarations -Wmissing-include-dirs -Woverloaded-virtual -Wredundant-decls -Wshadow -Wstrict-overflow=1 -Wswitch-default -Wfloat-conversion -Wunused")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O2 -Wall -Wextra -Wno-sign-compare -Wcast-align -Wctor-dtor-privacy -Wdisabled-optimization -Wformat=2 -Wmissing-declarations -Wmissing-include-dirs -Woverloaded-virtual -Wredundant-decls -Wshadow -Wstrict-overflow=1 -Wswitch-default -Wfloat-conversion -Wunused")
message(STATUS "Enabling AppleClang-specific build options.")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnull-dereference -Wdangling-else")

Expand Down

0 comments on commit 367d2c2

Please sign in to comment.