Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing issue in Utf8GraphQLRequestParser#ParseStringOrNull #7703

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Nov 8, 2024

Summary of the changes (Less than 80 chars)

  • Fixed parsing issue in Utf8GraphQLRequestParser#ParseStringOrNull.

Closes #7664


This fixes the main issue, but IMO ParseStringOrNull shouldn't return null for an empty string.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (02b1ca8) to head (0d843ff).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7703      +/-   ##
==========================================
- Coverage   73.95%   73.94%   -0.02%     
==========================================
  Files        2917     2917              
  Lines      151116   151117       +1     
  Branches    17560    17560              
==========================================
- Hits       111753   111737      -16     
- Misses      33507    33525      +18     
+ Partials     5856     5855       -1     
Flag Coverage Δ
unittests 73.94% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@michaelstaib michaelstaib merged commit 6bf4e4d into main Nov 10, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/issue-7664 branch November 10, 2024 12:40
@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 21, 2024
@glen-84 glen-84 added this to the HC-14.2.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utf8GraphQLRequestParser.Parse improve error message if OperationName is empty
2 participants