Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Huawei WLC AP Parsing crash on offline APs #762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JaRo5493
Copy link

General information

Affected Device: Huawei AC6508 Wireless LAN Controller (WLC)
Software Version: Huawei NMS Version 2.23.00.100.932
CheckMK Version: MSP 2.3.0p12
Issue Summary: The Huawei AC6508 WLC crashes when an offline Access Point (AP) is reported by the controller. The crash occurs due to an out-of-range access attempt on the aps_info2 list when the AP is no longer available, resulting in a system failure.

Bug reports

Operating System:
Debian 12 running Checkmk MSP 2.3.0p12

Steps to Reproduce:

  • Run a device discovery on a Huawei AC6508 WLC Controller with disconnected (offline) Access Points.
  • Run the attached string_table against the function parse_huawei_wlc_aps
    test.txt

SNMPWalk
Following File contains a Full SNMPWalk which is redacted.
Huawei AC6508 WLC snmpwalk.txt

Crash Report ID:
ID: 48274138-87a8-11ef-a33a-0050568fc548

Proposed changes

Expected Behavior:
When an AP goes offline, CheckMK should handle it gracefully, avoiding any out-of-range memory access. The system should log appropriate warnings or errors rather than attempting to access data from the unavailable AP.

Proposed Patch Change:
The patch modifies the AP handling logic to skip further parsing of AP information when the AP is not available. This prevents out-of-range access and stabilizes the system.

Fix out-of-range access of aps_info2 when the Huawei WLC reports an AP that is offline or unavailable.
Copy link

github-actions bot commented Oct 11, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@JaRo5493
Copy link
Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants