Use groovy stringParam over string or other non-default parameter spe…

…cification

Reduction of tech dept

Change-Id: Iaffd20030a9240cdb3216570ec581fe25f716932

buildscripts/scripts/build-cmk-packages.groovy

@@ -352,14 +352,12 @@ def main() {
     }
 }
 
-
 def get_agent_list(edition) {
     return (edition == "raw" ?
         ["windows"] :
         ["au-linux-64bit", "au-linux-32bit", "windows"]);
 }
 
-
 def build_linux_agent_updater(agent, edition, branch_version, registry) {
     print("FN build_linux_agent_updater(agent=${agent}, edition=${edition}, branch_version=${branch_version}, registry=${registry})");
 

buildscripts/scripts/test-agent-plugin-unit.groovy

@@ -36,4 +36,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-clang_tidy.groovy

@@ -21,5 +21,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-compile_cores.groovy

@@ -21,4 +21,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-gerrit.groovy

@@ -111,4 +111,5 @@ def main() {
         time_stage_started = test_gerrit_helper.log_stage_duration(time_stage_started);
     }
 }
+
 return this;

buildscripts/scripts/test-github-actions.groovy

@@ -23,4 +23,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-integration-docker.groovy

@@ -83,4 +83,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-iwyu.groovy

@@ -21,5 +21,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-package-cmk-agent-ctl.groovy

@@ -11,4 +11,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-package-livestatus.groovy

@@ -22,5 +22,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-python3-bandit.groovy

@@ -39,4 +39,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-python3-code-quality.groovy

@@ -14,4 +14,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-python3-format.groovy

@@ -21,5 +21,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-python3-pylint.groovy

@@ -13,5 +13,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-python3-unit-all.groovy

@@ -14,5 +14,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-shell-unit.groovy

@@ -11,5 +11,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/test-shell_format.groovy

@@ -20,6 +20,5 @@ def main() {
         );
     }
 }
-return this;
-
 
+return this;

buildscripts/scripts/test-shellcheck_agents.groovy

@@ -28,4 +28,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/test-unit-test-cores.groovy

@@ -39,4 +39,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/trigger-all-nightlies-fast.groovy

@@ -10,8 +10,8 @@ def main() {
     def editions = versioning.get_editions();
 
     def job_parameters = [
-        [$class: 'StringParameterValue',  name: 'CIPARAM_OVERRIDE_BUILD_NODE', value: params.TRIGGER_CIPARAM_OVERRIDE_BUILD_NODE],
-        [$class: 'StringParameterValue',  name: 'CIPARAM_BISECT_COMMENT', value: params.CIPARAM_BISECT_COMMENT],
+        stringParam(name: 'CIPARAM_OVERRIDE_BUILD_NODE', value: params.TRIGGER_CIPARAM_OVERRIDE_BUILD_NODE),
+        stringParam(name: 'CIPARAM_BISECT_COMMENT', value: params.CIPARAM_BISECT_COMMENT),
     ];
 
     def override_distros = params.EDITIONS.trim() ?: "";
@@ -32,7 +32,7 @@ def main() {
     for ( edition in editions ) {
         catchError(buildResult: "FAILURE", stageResult: "FAILURE") {
             stage("Trigger ${edition}") {
-                def this_job_parameters = job_parameters + [$class: 'StringParameterValue', name: 'EDITION', value: edition];
+                def this_job_parameters = job_parameters + [stringParam(name: 'EDITION', value: edition)];
 
                 print(
                     """

buildscripts/scripts/trigger-cmk-build-chain.groovy

@@ -32,28 +32,28 @@ def main() {
 
     /// NOTE: this way ALL parameter are being passed through..
     def job_parameters = [
-        [$class: 'StringParameterValue', name: 'EDITION', value: edition],
+        stringParam(name: 'EDITION', value: edition),
 
         // TODO perhaps use `params` + [EDITION]?
         // FIXME: all parameters from all triggered jobs have to be handled here
-        [$class: 'StringParameterValue',  name: 'VERSION', value: VERSION],
-        [$class: 'StringParameterValue',  name: 'OVERRIDE_DISTROS', value: params.OVERRIDE_DISTROS],
-        [$class: 'BooleanParameterValue', name: 'SKIP_DEPLOY_TO_WEBSITE', value: params.SKIP_DEPLOY_TO_WEBSITE],
-        [$class: 'BooleanParameterValue', name: 'DEPLOY_TO_WEBSITE_ONLY', value: params.DEPLOY_TO_WEBSITE_ONLY],
-        [$class: 'BooleanParameterValue', name: 'FAKE_WINDOWS_ARTIFACTS', value: params.FAKE_WINDOWS_ARTIFACTS],
-        [$class: 'StringParameterValue',  name: 'CIPARAM_OVERRIDE_DOCKER_TAG_BUILD', value: params.CIPARAM_OVERRIDE_DOCKER_TAG_BUILD],
-        [$class: 'BooleanParameterValue', name: 'SET_LATEST_TAG', value: params.SET_LATEST_TAG],
-        [$class: 'BooleanParameterValue', name: 'SET_BRANCH_LATEST_TAG', value: params.SET_BRANCH_LATEST_TAG],
-        [$class: 'BooleanParameterValue', name: 'PUSH_TO_REGISTRY', value: params.PUSH_TO_REGISTRY],
-        [$class: 'BooleanParameterValue', name: 'PUSH_TO_REGISTRY_ONLY', value: params.PUSH_TO_REGISTRY_ONLY],
-        [$class: 'BooleanParameterValue', name: 'BUILD_CLOUD_IMAGES', value: true],
-        [$class: 'StringParameterValue',  name: 'CUSTOM_GIT_REF', value: params.CUSTOM_GIT_REF],
-        [$class: 'StringParameterValue',  name: 'CIPARAM_OVERRIDE_BUILD_NODE', value: params.CIPARAM_OVERRIDE_BUILD_NODE],
-        [$class: 'StringParameterValue',  name: 'CIPARAM_CLEANUP_WORKSPACE', value: params.CIPARAM_CLEANUP_WORKSPACE],
-        [$class: 'StringParameterValue',  name: 'CIPARAM_BISECT_COMMENT', value: params.CIPARAM_BISECT_COMMENT],
+        stringParam(name: 'VERSION', value: VERSION),
+        stringParam(name: 'OVERRIDE_DISTROS', value: params.OVERRIDE_DISTROS),
+        booleanParam(name: 'SKIP_DEPLOY_TO_WEBSITE', value: params.SKIP_DEPLOY_TO_WEBSITE),
+        booleanParam(name: 'DEPLOY_TO_WEBSITE_ONLY', value: params.DEPLOY_TO_WEBSITE_ONLY),
+        booleanParam(name: 'FAKE_WINDOWS_ARTIFACTS', value: params.FAKE_WINDOWS_ARTIFACTS),
+        stringParam(name: 'CIPARAM_OVERRIDE_DOCKER_TAG_BUILD', value: params.CIPARAM_OVERRIDE_DOCKER_TAG_BUILD),
+        booleanParam(name: 'SET_LATEST_TAG', value: params.SET_LATEST_TAG),
+        booleanParam(name: 'SET_BRANCH_LATEST_TAG', value: params.SET_BRANCH_LATEST_TAG),
+        booleanParam(name: 'PUSH_TO_REGISTRY', value: params.PUSH_TO_REGISTRY),
+        booleanParam(name: 'PUSH_TO_REGISTRY_ONLY', value: params.PUSH_TO_REGISTRY_ONLY),
+        booleanParam(name: 'BUILD_CLOUD_IMAGES', value: true),
+        stringParam(name: 'CUSTOM_GIT_REF', value: params.CUSTOM_GIT_REF),
+        stringParam(name: 'CIPARAM_OVERRIDE_BUILD_NODE', value: params.CIPARAM_OVERRIDE_BUILD_NODE),
+        stringParam(name: 'CIPARAM_CLEANUP_WORKSPACE', value: params.CIPARAM_CLEANUP_WORKSPACE),
+        stringParam(name: 'CIPARAM_BISECT_COMMENT', value: params.CIPARAM_BISECT_COMMENT),
         // PUBLISH_IN_MARKETPLACE will only be set during the release process (aka bw-release)
-        [$class: 'BooleanParameterValue', name: 'PUBLISH_IN_MARKETPLACE', value: false],
-        [$class: 'StringParameterValue',  name: 'USE_CASE', value: use_case],
+        booleanParam(name: 'PUBLISH_IN_MARKETPLACE', value: false),
+        stringParam(name: 'USE_CASE', value: use_case),
     ];
 
     // TODO we should take this list from a single source of truth
@@ -127,6 +127,6 @@ def main() {
     }
 
     currentBuild.result = success ? "SUCCESS" : "FAILURE";
-
 }
+
 return this;

buildscripts/scripts/update-architecture-documentation.groovy

@@ -26,4 +26,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/utils/docker_util.groovy

@@ -8,4 +8,3 @@ load("${checkout_dir}/buildscripts/scripts/utils/docker_image_aliases_helper.gro
 get_docker_group_id = { it ->
     cmd_output("getent group docker | cut -d: -f3");
 }
-

buildscripts/scripts/winagt-build-cmk-agent-ctl.groovy

@@ -21,5 +21,5 @@ def main() {
         )
     }
 }
-return this;
 
+return this;

buildscripts/scripts/winagt-build-modules.groovy

@@ -33,4 +33,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/winagt-build.groovy

@@ -35,4 +35,5 @@ def main() {
         }
     }
 }
+
 return this;

buildscripts/scripts/winagt-test-build.groovy

@@ -18,5 +18,5 @@ def main() {
         );
     }
 }
-return this;
 
+return this;

buildscripts/scripts/winagt-test-integration.groovy

@@ -13,5 +13,5 @@ def main() {
         }
     }
 }
-return this;
 
+return this;

buildscripts/scripts/winagt-test-unit.groovy

@@ -11,5 +11,5 @@ def main() {
         )
     }
 }
-return this;
 
+return this;