SDK warning fixes #1267
Merged
SDK warning fixes #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added SDK warning fixes.
sneakzttv
added
ready-to-merge
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
kantagara and
rob1997
juans-chainsafe
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Most of the warnings (except Countly of course) were fixed! but I still see some of them remaining:
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(129,19): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(138,19): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(143,19): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(14,99): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(16,78): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.ramp/Runtime/Scripts/RampExchangerWebGL.cs(17,37): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Editor/WebGLResourceEmbedding.cs(12,9): warning CS0618: 'PlayerSettings.SetPropertyBool(string, bool, BuildTargetGroup)' is obsolete: 'Use explicit API instead.'
The GUID inside 'Assets/Samples/web3.unity SDK MUD/3.0.6.meta' cannot be extracted by the YAML Parser. Attempting to extract it via string matching instead. Please verify the file does not contain unexpected data.
The GUID inside 'Packages/io.chainsafe.web3-unity.ramp/Editor.meta' cannot be extracted by the YAML Parser. Attempting to extract it via string matching instead. Please verify the file does not contain unexpected data.
Also, I can't build on WebGL, getting this error:
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/IPFS/UploadPlatforms.cs(70,13): error CS0103: The name 'ImageSelected' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/IPFS/UploadPlatforms.cs(72,9): error CS0103: The name 'ImageSelected' does not exist in the current context
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/IPFS/UploadPlatforms.cs(91,13): error CS0103: The name 'ImageSelected' does not exist in the current context
|
oh i must have missed them, will fix, sorry. |
|
try that :) @juans-chainsafe |
sneakzttv
added
ready-to-merge
sneakzttv
added
ready-to-merge
sneakzttv
added
ready-to-merge
kantagara
approved these changes
Jan 9, 2025
juans-chainsafe
approved these changes
Jan 9, 2025
|
solid, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SDK warning fixes:
Removed a few unused variables.
Enabled nullable references in the scripts that use them.
Changed some variables to conditional to stop warnings.
This should remove SDK warnings, moving onto countly warnings next.
Closes #1222
Testing:
Right click in the folder hierarchy and press reimport all to make everything recopile, this will refresh the warnings and display them in the console. There should only be countly warnings remaining.
No documentation changes are needed in this PR.