refactor: flatten fork logic in notifyNewPayload #7385
+284
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7385 +/- ##
============================================
- Coverage 48.62% 48.44% -0.19%
============================================
Files 603 602 -1
Lines 40510 40407 -103
Branches 2071 2069 -2
============================================
- Hits 19700 19577 -123
- Misses 20772 20792 +20
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Jan 22, 2025
ensi321
changed the title
nflaig
reviewed
Jan 23, 2025
| serializedExecutionRequests, | ||
| ], | ||
| method, | ||
| params: generateSerializedNewPayloadParams(fork, method, {executionPayload}), |
There was a problem hiding this comment.
while this looks much cleaner here, we lose a lot of type safety
eg. it's possible to call it like this without complaints
params: generateSerializedNewPayloadParams(fork, method, {}),and then you will just notice this at runtime
nflaig
reviewed
Jan 30, 2025
| @@ -82,6 +85,22 @@ export type EngineApiRpcParamTypes = { | |||
| engine_getBlobsV1: [DATA[]]; | |||
| }; | |||
|
|
|||
| // Can extend keys to other engine API whenever it sees fit | |||
| export type EngineApiParamTypes = { | |||
There was a problem hiding this comment.
so while this type now makes the function call type safe it still offers the possibility that the type is not updated correctly, I was playing around with this locally and though to myself adding another type is not acceptable
How about we revert back to b29d470 and break down the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the current
notifyNewPayloadis structured does not allow new fork and payload method (eg. focil fork andengine_newPayloadV5) to be added easily without introducing more nested if statement.This PR flattens the logic into a single layer by having a switch statement which makes new methods to be added easily.