Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c8 based coverage reports for e2e and unit tests #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xTylerHolmes
Copy link

This PR adds c8 based coverage reports

@0xTylerHolmes 0xTylerHolmes requested a review from a team as a code owner March 4, 2023 22:09
@CLAassistant
Copy link

CLAassistant commented Mar 4, 2023

CLA assistant check
All committers have signed the CLA.

@dapplion
Copy link
Contributor

dapplion commented Mar 7, 2023

Should the coverage report be acted upon? i.e. upload to some remote tracker

@0xTylerHolmes
Copy link
Author

I left it as is just to gain some quick metrics and keep it simple.

If you want I could look into a good way to automate this and make another PR.

@dapplion
Copy link
Contributor

dapplion commented Mar 9, 2023

I left it as is just to gain some quick metrics and keep it simple.

If you want I could look into a good way to automate this and make another PR.

CC @wemeetagain

@wemeetagain
Copy link
Member

looks good, we just need to update the c8 version (now at 10.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants