Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperbridge Integration #526

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Hyperbridge Integration #526

wants to merge 10 commits into from

Conversation

ayushmishra2005
Copy link
Contributor

@ayushmishra2005 ayushmishra2005 commented Jan 9, 2025 •
edited
Loading

Description

Types of Changes

Please select the branch type you are merging and fill in the relevant template.

  • Hotfix
  • Release
  • Fix or Feature

Fix or Feature

Hyperbridge Integration

Types of Changes

  • Tech Debt (Code improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency upgrade (A change in substrate or any 3rd party crate version)

Migrations and Hooks

  • This change requires a runtime migration.
  • Modifies on_initialize
  • Modifies on_finalize

Checklist for Fix or Feature

  • Change has been tested locally.
  • Change adds / updates tests if applicable.
  • Changelog doc updated.
  • spec_version has been incremented.
  • network-relayer's events have been updated according to the blockchain events if applicable.
  • All CI checks have been passed successfully

Checklist for Hotfix

  • Change has been deployed to Testnet.
  • Change has been tested in Testnet.
  • Changelog has been updated.
  • Crate version has been updated.
  • spec_version has been incremented.
  • Transaction version has been updated if required.
  • Pull Request to dev has been created.
  • Pull Request to staging has been created.
  • network-relayer's events have been updated according to the blockchain events if applicable.
  • All CI checks have been passed successfully

Checklist for Release

  • Change has been deployed to Devnet.
  • Change has been tested in Devnet.
  • Change has been deployed to Qanet.
  • Change has been tested in Qanet.
  • Change has been deployed to Testnet.
  • Change has been tested in Testnet.
  • Changelog has been updated.
  • Crate version has been updated.
  • Spec version has been updated.
  • Transaction version has been updated if required.
  • All CI checks have been passed successfully

seunlanlege
seunlanlege reviewed Jan 10, 2025
View reviewed changes
runtime/cere-dev/src/hyperbridge_ismp.rs Outdated
// configure the runtime event
type RuntimeEvent = RuntimeEvent;
// Configured as Pallet Ismp
type Dispatcher = Ismp;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pallet-hyperbridge as your dispatcher

Suggested change
type Dispatcher = Ismp;
type Dispatcher = pallet_hyperbridge::Pallet<Runtime>;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

seunlanlege
seunlanlege reviewed Jan 10, 2025
View reviewed changes
runtime/cere/src/hyperbridge_ismp.rs Outdated
// configure the runtime event
type RuntimeEvent = RuntimeEvent;
// Configured as Pallet Ismp
type Dispatcher = Ismp;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ayushmishra2005 ayushmishra2005 marked this pull request as ready for review January 10, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunlanlege seunlanlege Awaiting requested review from seunlanlege

At least 2 approving reviews are required to merge this pull request.

Assignees

@ayushmishra2005 ayushmishra2005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushmishra2005 @seunlanlege