Feature/authentication frontend #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XanderVertegaal
commented
May 4, 2024
XanderVertegaal
commented
May 4, 2024
XanderVertegaal
commented
May 4, 2024
| validators: identicalPasswordsValidator<keyof RegisterForm>('password1', 'password2') | ||
| }); | ||
|
|
||
| public usernameErrors$ = controlErrorMessages$(this.form, 'username'); |
There was a problem hiding this comment.
Instead of creating an stream of error messages here and using them with | async in the template, we could also create a pipe that extracts them from a control in the template. Something like:
<p *ngFor="let error of form.controls.username | controlErrors ">{{ error }}</p>
lukavdplas
requested changes
May 13, 2024
backend/source/models.py
Outdated
Comment on lines
17
to
25
| medieval_title = models.CharField( | ||
| max_length=255, blank=True, help_text="The original title of the work, if known" | ||
| ) | ||
|
|
||
| medieval_author = models.CharField( | ||
| max_length=255, | ||
| blank=True, | ||
| help_text="The name of the original author of the work, if known", | ||
| ) |
There was a problem hiding this comment.
original_title / original_author sounds more appropriate to me, but I'll leave it to your judgement.
frontend/src/app/user/user-settings/user-settings.component.html
Outdated
Show resolved
Hide resolved
lukavdplas
reviewed
Jun 12, 2024
lukavdplas
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a number of points listed under 'Frontend' in #38. It also introduces (NgBootstrap) toasts for app-wide notifications.
There are a few issues that could still be implemented. This PR is getting quite big, however, so I wanted to have this reviewed first before I introduce more moving parts / complexity.
Open issues
/home) (Authentication-based routing #68)