Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use window.jQuery instead of window.$ to avoid clashes #99

Merged
merged 2 commits into from
Apr 9, 2024
Merged

use window.jQuery instead of window.$ to avoid clashes #99

merged 2 commits into from
Apr 9, 2024

Conversation

bbonf
Copy link
Contributor

@bbonf bbonf commented Apr 4, 2024

No description provided.

@bbonf bbonf requested a review from tymees April 4, 2024 10:15
tymees
tymees approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@tymees tymees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels like Vue is at fault here, but seeing as this is a library project I'm fine with this less-conflict-prone approach

@bbonf bbonf changed the base branch from master to develop April 9, 2024 09:33
@bbonf bbonf merged commit 9c56f9d into develop Apr 9, 2024
4 checks passed
@bbonf bbonf deleted the fix/jquery-dollar branch April 9, 2024 09:34
@tymees tymees mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymees tymees tymees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbonf @tymees