IndexJob model #1699
Merged
IndexJob model #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tasks method
lukavdplas
added
backend
Closed
JeltevanBoheemen
requested changes
Jan 30, 2025
backend/es/es_index.py
Outdated
| if rollover and not prod: | ||
| logger.warning( | ||
| 'rollover flag is set but prod flag not set -- no effect') | ||
| # tasks below are added in order of execution for readability |
There was a problem hiding this comment.
If/else monstrosity :(
I would cut the below part up into separate utility functions (one for each toplevel if/else) with some documentation on what decision is made here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
IndexJobmodel to track indexing commands -> close #1696The
IndexJobdescribes a set of index-related tasks. (E.g. create new index for a corpus, populate it with documents, and update the alias.) Tasks are broken up intoIndexTaskmodels.At this point, the
IndexJobis essentially a log for theindexandaliascommands; you can't create a job and then run it. Also, the model does not include status tracking. I'll tackle these in #1697Functions related to indexing commands are refactored. The
indexandaliasnow create anIndexJobto describe the command, and then callperform_indexing(job)to run it. This makes up the most hefty changes in code, as it separates "figuring out what to do" from actually doing it.There is a new
indexingapp which contains indexing-related models. This was to keepmodels.pyfrom becoming too bloated. Functions and commands related to indexing should probably be moved to this app eventually, but I did not do that here.The
indexandaliascommands still work as before, with a few slight changes toindex:--add, like you would in production mode. Runningpython manage.py index mycorpuswhen the index already exists will raise an error, unless you use--deleteor--add.--updateno longer excludes the option to use--rollover.(the crowd goes wild)Small addition:
min_date/max_datein a Python corpus definition as adatetype instead ofdatetime. Though individual corpora may still implementsources()in a way that doesn't support this.Deployment configuration
The
'indexing'app must be added in the project settings.