Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/json corpus api #1569

Merged
merged 10 commits into from
May 16, 2024
Merged

Feature/json corpus api #1569

merged 10 commits into from
May 16, 2024

Conversation

lukavdplas
Copy link
Contributor

Builds on #1547 : implements the backend API for managing corpus definitions. Preparation for #982

  • Adapts the import_json / export_json modules to work with a DRF ModelSerializer
  • Adds a viewset for listing / creating / updating JSON corpus definitions to the API.

You can now view and import JSON corpus definitions using the API.

@lukavdplas lukavdplas mentioned this pull request May 15, 2024
Merged
@lukavdplas lukavdplas added backend changes to the django backend enhancement improvements to user functionality labels May 15, 2024
JeltevanBoheemen
JeltevanBoheemen approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@JeltevanBoheemen JeltevanBoheemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was present for most of the coding, so only took a precise look at update, which looks good!

Base automatically changed from feature/corpus-json-export to develop May 16, 2024 14:25
@lukavdplas lukavdplas marked this pull request as ready for review May 16, 2024 14:29
@lukavdplas lukavdplas merged commit 75a331d into develop May 16, 2024
2 checks passed
@lukavdplas lukavdplas deleted the feature/json-corpus-api branch May 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeltevanBoheemen JeltevanBoheemen JeltevanBoheemen approved these changes

Assignees
No one assigned
Labels
backend changes to the django backend enhancement improvements to user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukavdplas @JeltevanBoheemen