This repository has been archived by the owner on Dec 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Cassianky
commented
Nov 16, 2023
•
edited
Loading
edited
- Filter activities by ratings
- Completed UI of reviews on activity details page
…ent-cassia-reviews
7 tasks
Cassianky
changed the title
[Client] Reviews Display
[Client] Reviews Display - Completed
Nov 17, 2023
ayangler
reviewed
Nov 18, 2023
], | ||
}); | ||
|
||
if (foundActivity.reviews.length > 0 && foundActivity.reviews) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! One thing is that the admin can hide reviews from the activity page in the admin FE
Once an admin hides a review I feel we can exclude it from calculation?
Maybe something like this will work
if (foundActivity.reviews.length > 0 && foundActivity.reviews) {
const visibleReviews = foundActivity.reviews.filter(review => !review.hidden);
if (visibleReviews.length > 0) {
const totalRatings = visibleReviews.reduce(
(sum, review) => sum + review.rating,
0
);
foundActivity.averageRating = totalRatings / visibleReviews.length;
} else {
foundActivity.averageRating = 0;
}
for (const review of visibleReviews) {
let preSignedPhoto = await s3GetImages(review.client.photo);
review.client.preSignedPhoto = preSignedPhoto;
}
foundActivity.reviews = visibleReviews
} else {
foundActivity.averageRating = 0;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okie resolved
select: "-booking", | ||
}); | ||
|
||
function findAverageRating(activity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async function findAverageRating(activity) {
if (activity.reviews && activity.reviews.length > 0) {
const visibleReviews = activity.reviews.filter(review => !review.hidden);
if (visibleReviews.length > 0) {
const totalRatings = visibleReviews.reduce(
(sum, review) => sum + review.rating,
0
);
return totalRatings / visibleReviews.length;
} else {
return 0;
}
} else {
return 0;
}
}
if you're using the nested reviews here as well prolly need to update the attribute to the actual visibleReviews
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.