-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine-grained tests for herg QC #23
Conversation
…/pcpostprocess into HEAD
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Would it be possible/worth it to rewrite QCDict so that it inherits from UserDict? It seems like we're replicating a few basic dictionary functions. It might not be worth the effort, but if it's simple to do it might simplify the code a little bit |
Description
Supports #21
qc_1()
,qc_2()
, etc.) now returns(bool, value)
tuples indicating pass/fail and the checked value.hERGQC.run_qc()
now returns aQCDict
object which contains the results from all QC checks.QCDict.all_passed()
returns abool
for whether all checks passed.QCDict.passed_list()
returns a list ofbool
s, one for each check.QCDict.qc_passed(label)
returns abool
for a specific check.Types of changes
Testing
Documentation checklist