Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check points passed to equation_of_line differ #13

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

jwallwork23
Copy link
Collaborator

Closes #8.

This PR adds a check that the two points passed to equation_of_line are not identical. If they are, there are infinitely many lines passing through the points so we raise an error.

The PR also adds a test to check that this error gets raised as expected.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jun 25, 2024
@jwallwork23 jwallwork23 self-assigned this Jun 25, 2024
Copy link
Member

@TomMelt TomMelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TomMelt TomMelt merged commit c947660 into main Jul 10, 2024
1 check passed
@TomMelt TomMelt deleted the check_points_differ branch July 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check points differ
2 participants