Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the refactored NN back into SAM #4

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add the refactored NN back into SAM #4

wants to merge 10 commits into from

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Jun 6, 2023

Add the refactored NN for convection parameterisation back into SAM.

  • Update the README so it is clear what this repo is and how it differs from the original
  • Adapt SAM to use our implementation
  • Switch between Janni and new with namelist flag
  • Import our source code from Convection repo
  • Check it compiles and runs OK
  • Compare outputs (and document in README how this can be manually diff'd)

…ded in namelist. WIP - needs our NN source adding.
@jatkinson1000 jatkinson1000 self-assigned this Jun 6, 2023
@jatkinson1000 jatkinson1000 requested a review from dorchard June 6, 2023 14:50
@dorchard
Copy link
Member

dorchard commented Jun 8, 2023

Great. First two tasks look done? Can we do a submodule for task 3 (to import from the convection repo)?

@jatkinson1000
Copy link
Member Author

Great. First two tasks look done? Can we do a submodule for task 3 (to import from the convection repo)?

Mostly, just need to check and then I'll tick off.
Considered a submodule, but just want the source files rather than the whole repo, and preferably adjacent to the code rather than in a subdirectory for building purposes... Can discuss later today perhaps?

@raehik
Copy link

raehik commented Aug 14, 2023

Some conflicting function/subroutine names between the original and refactored NN code made the "switching" awkward. @dorchard suggested we gate with CPP instead -- looking into it next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants