Fixes regarding pip packages #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…place-dashes-in-names # Conflicts: # pydeps2env/environment.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@CagtayFabry the live-action-testing, showing that this works can be seen in action here: https://github.com/BAMWelDX/weldx/actions/runs/11517821846/job/32073255437 |
5 tasks
CagtayFabry
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I reworked this slightly so that pip and conda names can be exported (depending on which export format is chosen)
shuld be ready no, thanks @marscher 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pypi package names with a reverse mapping generated from Parselmouth. The Parcelmouth Python package generates a (redundant) mapping of conda to pypi names. We use that to create a reverse mapping while filtering out names, which are not being changed.
This Pr also changes the following behaviour. When pip requirements (as they are contained in pip format in pyproject.toml) contain an extras definition (e.g. setuptools-scm[toml]) the extras will expanded during environment creation.
Partially fixes #6