Prevent scheduleRebuild from being called off-thread
#2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellysquid3
approved these changes
Dec 9, 2023
jellysquid3
pushed a commit
that referenced
this pull request
Dec 9, 2023
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mods try to schedule chunks to be rebuilt on background threads. In vanilla, this pattern generally manages to work due to how the chunk data structures are built, however, Sodium is much more sensitive to concurrency errors & crashes. To avoid undefined behavior, we simply throw an exception when
scheduleRebuildis not called on the main thread.