Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes path bug in list_phones. #516

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

kylebgorman
Copy link
Collaborator

@kylebgorman kylebgorman commented Feb 15, 2024

This referred to a non-existent command-line argument. Tested with:

    ./list_phones.py ../../scrape/tsv/ben_beng_broad.tsv
  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

This referred to a non-existent command-line argument. Tested with:

        ./list_phones.py ../../scrape/tsv/ben_beng_broad.tsv
Copy link
Collaborator

@Othergreengrasses Othergreengrasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@kylebgorman
Copy link
Collaborator Author

Submitting over tests (which are all broken re: #514).

@kylebgorman kylebgorman merged commit 3a7d452 into CUNY-CL:master Feb 15, 2024
4 of 9 checks passed
@kylebgorman kylebgorman deleted the list_phones branch February 15, 2024 14:53
kylebgorman added a commit to kylebgorman/wikipron that referenced this pull request Feb 21, 2024
kylebgorman added a commit to kylebgorman/wikipron that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants