Merge previous release changes for Keyterms #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration change didn't need to be committed with key-terms. Also we'd most like let this in the `private.py` environment file rather than hard code it in `common.py`.
…lly. When running devstack environment this `./envs/production.py` import for the `private.py` needs to not be included in this file because it is imported a second time at the end of `./envs/devstack.py`. Having it imported twice it will only import the first `./envs/private.py` file. This causes issues when you think that you're overriding a FEATURE flag and `./envs/devstack.py` updates that flag after the `./envs/private.py` has already been imported.
- Added `ENABLE_KEY_TERMS_GLOSSARY` Feature flag to enable key terms glossary for the platform. - Added error handling if `key-terms-api` is not found. - Setup the Glossary tab to be hideable or movable if needed.
Need to point to the new MFE for `frontend-app-course-authoring` to display key terms functionality.
- Added in `textbooks_api` endpoints to retrieve textbook search results for `keyterms-api` from the CMS. - Updated `keyterms_reindex` to have proper error handling for `CourseReindexView.get` call from the `keyterms_api`.
becdavid
force-pushed
the
feature.nutmeg/keyterms
branch
2 times, most recently
from
ea1e342 to
865625b
Compare
becdavid
force-pushed
the
feature.nutmeg/keyterms
branch
from
865625b to
3317838
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.