[CBRD-25765] System Catalog refactoring for consistency #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Renamed attribute macros from TR_ATT_* to CT_TRIGGER_ATTR_* for better clarity and consistency. 2. Added get_trigger function to the db_trigger system catalog in schema_system_catalog_install.cpp 3. Fixed bugs: Ensured class_attribute default values, including condition_time and action_time, are properly initialized.
- from "catcls_add_collations" to "catcls_add_collation" - from "catcls_add_charsets" to "catcls_add_charset"
kangmin5505
requested review from
hgryoo,
kisoo-han,
beyondykk9,
jongmin-won,
hyunikn and
ctshim
and removed request for
hornetmj and
beyondykk9
1. Removed unnecessary extern keywords from schema_system_catalog.hpp. 2. Relocated system_catalog_query_spec declarations from schema_system_catalog_install.hpp to a new header file, schema_system_catalog_install_query_spec.hpp, to improve modularity and organization.
kangmin5505
force-pushed
the
CBRD-25765
branch
from
86d4801 to
3a93623
Compare
… catalog definition
Replaced incorrect `CT_QUERYSPEC_NAME` with `CT_INDEX_NAME` and `CT_INDEXKEY_NAME`.
|
fig-cake 릴리즈 후 다시 정리하여 reopen 하겠습니다. |
- Every system classes are marked already at authenticate_context::install() and system_catalog_builder::create_and_mark_system_class().
kangmin5505
removed request for
hgryoo,
kisoo-han,
beyondykk9,
jongmin-won,
hyunikn and
ctshim
kangmin5505
force-pushed
the
CBRD-25765
branch
from
22baebb to
92e5e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25765
설명
사용자의 인터페이스 변경 없이, 반복되는 코드 및 코드의 일관성 리팩토링
주요 수정 사항
trigger_manager.c에 있던 db_trigger를schema_system_catalog_install.cpp로 이동 및 매크로 리팩토링[26f21d8]