Perform python version check earlier #269
Open
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Feb 1, 2022
| @@ -12,6 +12,7 @@ | |||
| from pathlib import Path | |||
|
|
|||
| sys.path.append(str(Path(__file__).parent.parent)) | |||
| import pycheribuild.check_version # noqa | |||
There was a problem hiding this comment.
We probably don't need this for the tests, but adding it to the main entry point seems reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be nice to just have a single file where we bump the version to the maximum of all the requirements we have (that can safely be included first), for at least a couple of the top-level scripts. I left a more permissive noqa rather than noqa: E402 on some of the imports because nothing is actually imported and this would fail another flake8 check.