Make relaxed-comparison the default #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislaus
force-pushed
the
faf28_strictness
branch
from
9ce4d03 to
3a92788
Compare
utils/scripts/runTestRIG.py
Outdated
| @@ -559,7 +559,7 @@ def spawn_vengine(name, mport, iport, arch, log): | |||
| if args.timeout: | |||
| cmd += ['--timeout', str(int(args.timeout * 1000000))] | |||
| if args.no_shrink: | |||
| cmd += ['-S'] | |||
| cmd += ['-S'] | |||
There was a problem hiding this comment.
Any reason why you added an extra indent here?
There was a problem hiding this comment.
No, just a mistake...fixed now.
There was a problem hiding this comment.
Thanks, do you mind squashing those last two commits into one?
There was a problem hiding this comment.
That should be done automatically in the "squash and merge" option from github, right? I would want all of them to be squashed into one commit.
marnovandermaas
approved these changes
Apr 26, 2024
PeterRugg
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes relaxed comparison the default method and adds a flag that if set mandates strict comparison.